Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API keys are only accepted by the /track/* and /user/limits endpoints #173

Merged
merged 3 commits into from
Mar 30, 2022
Merged

API keys are only accepted by the /track/* and /user/limits endpoints #173

merged 3 commits into from
Mar 30, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 24, 2022

PULL REQUEST

Overview

API keys are only accepted by the /track/* and /user/limits endpoints

API keys cannot be used via a GET parameter.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

@ro-tex
API keys are only accepted by the /track/* and /user/limits endpo…
ceaa059 
…ints.

API keys cannot be used via a GET parameter.
@ro-tex ro-tex self-assigned this Mar 24, 2022
peterjan
peterjan reviewed Mar 25, 2022
View reviewed changes
api/routes.go Outdated Show resolved Hide resolved
peterjan
peterjan reviewed Mar 25, 2022
View reviewed changes
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a unit test that asserts API keys are no longer accepted by most routes?

ChrisSchinnerl
ChrisSchinnerl reviewed Mar 25, 2022
View reviewed changes
test/api/apikeys_test.go Show resolved Hide resolved
api/routes.go Outdated Show resolved Hide resolved
@ro-tex
Merge branch 'main' into ivo/limit_api_keys
f3f4824 
# Conflicts:
#	api/routes.go
@ro-tex
Copy link
Contributor Author

ro-tex commented Mar 25, 2022 •
edited
Loading

should we add a unit test that asserts API keys are no longer accepted by most routes?

I'm not sure how useful that would be but I added it.

@ro-tex ro-tex merged commit a673b7b into main Mar 30, 2022
@ro-tex ro-tex deleted the ivo/limit_api_keys branch March 30, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwypchlo kwypchlo kwypchlo approved these changes

@peterjan peterjan peterjan approved these changes

@ChrisSchinnerl ChrisSchinnerl Awaiting requested review from ChrisSchinnerl ChrisSchinnerl is a code owner

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ro-tex @peterjan @kwypchlo @ChrisSchinnerl