Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ON HOLD] User name and profile picture fields #178

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[ON HOLD] User name and profile picture fields #178

wants to merge 3 commits into from

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Mar 31, 2022 •
edited
Loading

PULL REQUEST

Overview

Adds name and profilePic fields to the User struct.
Allows their change via PUT /user.

Note:
This PR also includes the changes from #177. We need that in order for the tests to pass.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

Closes #156

@ro-tex ro-tex self-assigned this Mar 31, 2022
ChrisSchinnerl
ChrisSchinnerl reviewed Mar 31, 2022
View reviewed changes
database/user.go Outdated Show resolved Hide resolved
api/handlers.go Show resolved Hide resolved
@ro-tex ro-tex marked this pull request as draft April 1, 2022 13:34
@ro-tex ro-tex marked this pull request as ready for review April 4, 2022 11:09
@ro-tex
Copy link
Contributor Author

ro-tex commented Apr 4, 2022

So, rebasing from the UI does a force-push. Noted.

ChrisSchinnerl
ChrisSchinnerl previously approved these changes Apr 4, 2022
View reviewed changes
@ro-tex ro-tex requested a review from peterjan April 5, 2022 09:41
@ro-tex
Merge branch 'main' into ivo/user_fields
ea0fcd0 
# Conflicts:
#	test/api/handlers_test.go
#	test/tester.go
@ro-tex ro-tex marked this pull request as draft April 5, 2022 14:34
@ro-tex
Copy link
Contributor Author

ro-tex commented Apr 5, 2022

Converting to draft because we probably won't need this.

@ro-tex ro-tex changed the title User name and profile picture fields [ON HOLD] User name and profile picture fields Apr 6, 2022
@peterjan peterjan removed their request for review April 12, 2022 06:54
@meeh0w meeh0w removed their request for review June 20, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@ro-tex ro-tex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[don't implement] Add new fields to user model
2 participants
@ro-tex @ChrisSchinnerl