F/U Tester refactoring #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename all `bb`s to `b`s.
Remove the `logger` parameter from `test.NewDatabase`, as it's not needed. Remove an unnecessary `switch` statement.
peterjan
reviewed
Apr 5, 2022
peterjan
approved these changes
Apr 5, 2022
ChrisSchinnerl
approved these changes
Apr 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Overview
This PR resolves the comments linked in issue #186 and, more importantly, resolves complication issues caused by merged code. We need to merge this in before we can merge anything else.
Example for Visual Changes
Checklist
Review and complete the checklist to ensure that the PR is complete before assigned to an approver.
Issues Closed
Closes #186