Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.18 for the JSWKS generator. #220

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Jun 9, 2022

PULL REQUEST

Overview

Karol reported that while running make docker-generate on xyz he encountered

/go/pkg/mod/github.com/ory/x@v0.0.368/jsonx/get.go:19:13: f.IsExported undefined (type reflect.StructField has no field or method IsExported)
The command '/bin/sh -c go get github.com/ory/hydra/jwk' returned a non-zero code: 2
make: *** [Makefile:165: docker-generate] Error 2

and I confirmed that locally. Upgrading the go image to 1.18 fixes the incompatibility.

Example for Visual Changes

Checklist

  • All git commits are signed. (REQUIRED)
  • All new methods or updated methods have clear docstrings.
  • Testing added or updated for new methods.
  • Verified if any changes impact the WebPortal Health Checks.
  • Appropriate documentation updated.
  • Changelog file created.

Issues Closed

@ro-tex ro-tex self-assigned this Jun 9, 2022
@ChrisSchinnerl ChrisSchinnerl merged commit 09c763e into main Jun 9, 2022
@ChrisSchinnerl ChrisSchinnerl deleted the ivo/generator_go_version branch June 9, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants