Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test-long in CI #222

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Enable test-long in CI #222

merged 3 commits into from
Jun 14, 2022

Conversation

MSevey
Copy link
Contributor

@MSevey MSevey commented Jun 10, 2022

PULL REQUEST

Overview

This PR fixes some lint errors, cleans up the Makefile, addresses missed testing.Short() calls, and enables the long tests in CI.

Example for Visual Changes

Checklist

  • All git commits are signed. (REQUIRED)
  • All new methods or updated methods have clear docstrings.
  • Testing added or updated for new methods.
  • Verified if any changes impact the WebPortal Health Checks.
  • Appropriate documentation updated.
  • Changelog file created.

Issues Closed

@linear
Copy link

linear bot commented Jun 10, 2022

SKY-971 Enable Accounts mongo test in CI

MSevey
MSevey commented Jun 10, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@MSevey MSevey enabled auto-merge June 12, 2022 12:21
@MSevey MSevey requested a review from meeh0w June 14, 2022 13:10
@MSevey MSevey merged commit 2ea3f61 into main Jun 14, 2022
@MSevey MSevey deleted the matt/sky-971-enable-accounts-mongo-test-in-ci branch June 14, 2022 17:04
@ro-tex ro-tex mentioned this pull request Jun 20, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwypchlo kwypchlo kwypchlo approved these changes

@ChrisSchinnerl ChrisSchinnerl ChrisSchinnerl approved these changes

@ro-tex ro-tex Awaiting requested review from ro-tex ro-tex is a code owner

@meeh0w meeh0w Awaiting requested review from meeh0w

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MSevey @kwypchlo @ChrisSchinnerl