Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stripe Endpoints #80

Merged
merged 8 commits into from
Apr 12, 2022
Merged

Stripe Endpoints #80

merged 8 commits into from
Apr 12, 2022

Conversation

ro-tex
Copy link
Contributor

@ro-tex ro-tex commented Oct 4, 2021

PULL REQUEST

Overview

This PR introduces three new endpoints for talking to Stripe. These were previously implemented under the portal code but we want to get rid of the portal code's backend component.

Example for Visual Changes

Checklist

Review and complete the checklist to ensure that the PR is complete before assigned to an approver.

  • All new methods or updated methods have clear docstrings
  • Testing added or updated for new methods
  • Verify if any changes impact the WebPortal Health Checks
  • Approriate documentation updated
  • Changelog file created

Issues Closed

Closes #157

@ro-tex ro-tex self-assigned this Oct 4, 2021
@ro-tex ro-tex added the enhancement New feature or request label Apr 6, 2022
@ro-tex ro-tex closed this Apr 6, 2022
@ro-tex ro-tex reopened this Apr 6, 2022
@ro-tex ro-tex reopened this Apr 6, 2022
Update stripe library to latest version.
Add a tester flag that controls whether it follows redirects or not.
api/stripe.go Show resolved Hide resolved
api/stripe.go Show resolved Hide resolved
@ro-tex ro-tex marked this pull request as ready for review April 7, 2022 13:23
@ro-tex ro-tex requested review from peterjan and meeh0w and removed request for kwypchlo April 7, 2022 13:33
Copy link

@meeh0w meeh0w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about the payments history? Or do we want to redirect users to Stripe for that information? /cc @dghelm

api/stripe.go Show resolved Hide resolved
Copy link

@peterjan peterjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, just waiting to see whether you think we should alter the prices endpoint

api/routes.go Show resolved Hide resolved
main.go Show resolved Hide resolved
test/tester.go Show resolved Hide resolved
@dghelm
Copy link

dghelm commented Apr 11, 2022

What about the payments history? Or do we want to redirect users to Stripe for that information? /cc @dghelm

In-dashboard payment history seems nice to me, but I'm also open to having that be another round of updates -- let's discuss in the meeting on Wednesday.

@ChrisSchinnerl ChrisSchinnerl merged commit 6a2cab8 into main Apr 12, 2022
@ChrisSchinnerl ChrisSchinnerl deleted the ivo/stripe_endpoints branch April 12, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-implement Stripe integration
5 participants