Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup testing infrastructure #6

Merged
merged 10 commits into from
Jul 27, 2022
Merged

Setup testing infrastructure #6

merged 10 commits into from
Jul 27, 2022

Conversation

meeh0w
Copy link
Contributor

@meeh0w meeh0w commented Jul 23, 2022 •
edited
Loading

Overview

  • Restructures the service to make it more testable
  • Adds Winston as a logger
  • Adds tests for the service
  • Adds test coverage reporting for PRs

Checklist

  • All git commits are signed. (REQUIRED)
  • All new methods or updated methods have clear docstrings.
  • Testing added or updated for new methods.
  • Verified if any changes impact the WebPortal Health Checks.
  • Appropriate documentation updated.
  • Changelog file created.

@meeh0w meeh0w requested review from ro-tex and MSevey July 23, 2022 14:52
@meeh0w meeh0w requested a review from kwypchlo as a code owner July 23, 2022 14:52
@linear
Copy link

linear bot commented Jul 23, 2022

SKY-1325 Setup testing infrastructure for Handshake API

@codecov
Copy link

codecov bot commented Jul 23, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (main@d590881). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #6   +/-   ##
=======================================
  Coverage        ?   97.43%           
=======================================
  Files           ?        3           
  Lines           ?       78           
  Branches        ?       18           
=======================================
  Hits            ?       76           
  Misses          ?        2           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d590881...28e8194. Read the comment docs.

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 23, 2022
View reviewed changes
ro-tex
ro-tex requested changes Jul 25, 2022
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 26, 2022
View reviewed changes
src/server.js
res
.status(this.getStatusCodeForError(error))
.contentType("text/plain; charset=utf-8")
.send(`Handshake error: ${error.message}`);

Check warning

Code scanning / CodeQL

Reflected cross-site scripting

Cross-site scripting vulnerability due to [user-provided value](1).
src/server.js
res
.status(this.getStatusCodeForError(error))
.contentType("text/plain; charset=utf-8")
.send(`Handshake error: ${error.message}`);

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML

[Exception text](1) is reinterpreted as HTML without escaping meta-characters.
@meeh0w meeh0w requested a review from ro-tex July 26, 2022 20:27
@kwypchlo kwypchlo merged commit 0d29f3b into main Jul 27, 2022
@kwypchlo kwypchlo deleted the SKY-1325 branch July 27, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwypchlo kwypchlo kwypchlo approved these changes

@ro-tex ro-tex ro-tex approved these changes

@MSevey MSevey MSevey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@meeh0w @ro-tex @kwypchlo @MSevey