Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add critical health check for number of workers on cooldown #14

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

kwypchlo
Copy link
Contributor

@kwypchlo kwypchlo commented Jun 27, 2022

  • added new critical health check that fails when number of workers on cooldown to total number of workers ratio is more than a certain threshold (currently set to 60%)
  • dropped passing external server ip on local skyd check (would falsely report error every time, harmless since it was just printing that when real issue occurred but pretty confusing)
  • critical fix: registry entry debug serialiser was failing since entries have BigInt revision (whole health check fails to finish if that happens, very critical bug fix)

@kwypchlo kwypchlo self-assigned this Jun 27, 2022
@linear
Copy link

linear bot commented Jun 27, 2022

@kwypchlo kwypchlo merged commit 4e31048 into main Jun 27, 2022
@kwypchlo kwypchlo deleted the karol/sky-1112-add-critical-health-check-for-number-of branch June 27, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants