[NO JIRA]: Disable loadable in CSR build #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaysonwu991
commented
Feb 15, 2023
| @@ -1,6 +1,5 @@ | |||
| "use strict"; | |||
|
|
|||
| const postcssNormalize = require("postcss-normalize"); | |||
There was a problem hiding this comment.
This module is unused, just remove it.
jaysonwu991
commented
Feb 15, 2023
Comment on lines
+3
to
+5
| ## 10.1.0 | ||
|
|
||
| - Disable `loadable` in CSR build |
There was a problem hiding this comment.
Even though it is a big change to CSR build, but no any breaking is here for BRS, so a minor version is OK.
|
Thanks @jaysonwu991 , have you tested this locally with the impacted microsite & libs to make sure it fixes the issue? |
Hi @runmoore , yep, have tested, the issue is gone and no breaking to the microsites that use CSR build. |
|
Thanks @jaysonwu991 , this is a nice solution to the problem |
runmoore
approved these changes
Feb 16, 2023
xalechez
pushed a commit
that referenced
this pull request
Apr 20, 2023
* disable loadable in CSR build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
After SSR build feature was integrated into
forkbranch and beta versions were removed, there are some issues exist for CSR build, but it didn't happen once integration because some microsites/tools at Skyscanner weren't up-to-date with the latest version that had SSR build feature.js-tag-managerupgraded BRS to the latest version just a few months ago, and it caused an ILD after upgrading, but when it downgraded to BRS v9, the ILD issue disappeared, so it was obvious that SSR build integration caused this issue.@samstradling tried to fixed this issue, he raised a PR #155 to do something about the configuration of
loadable, but the changes might have impact with SSR build because it did useloadable.To solve this issue, better to disable
loadablein CSR build as-was (Before SSR build integration), it is safe for us to do this because it won't break anything to BRS, it means engineers won't need to do anything for this change.Change List
loadablein CSR buildrequirestatement