[ARGG-784]: Release pipeline for cra5 testing #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliecurtis
force-pushed
the
argg-784-brs-fork-release-pipeline
branch
from
bf2f6dd
to
bdc77c6
Compare
|
Not 100% sure why linting is complaining on files I have not touched right now. Keeping an eye out for it though |
olliecurtis
commented
Oct 10, 2023
There was a problem hiding this comment.
I updated this as it had all references to our internal artifactory so couldn't pull any dependencies to allow CI to work
soulcheck
reviewed
Oct 11, 2023
soulcheck
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
LGTM
Looks like setup-node supports package caching out of the box, but if that works would require a separate investigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: More changes were made in this PR than just simply adding a
ymlfile because when the CI was running it was complaining that the linting checks were failing so they needed to be fixed possibly because the lockfile was pointing at artifactory so could never get the deps to properly check.As part of our work for testing CRA 5, we want to setup releases for each time we merge to the
fork_cra5branch for dev releases so this PR adds this ability to the branch.The idea behind this is for quick testing purposes when we merge into the branch an
alphatag version is released to npm for allowing us to test with changes.Then for stable and betas we would still do that manually for now and then when it comes to it we would have CI that would push stables in fork later on!