[BPK-2106] Remove line height from BpkTextInput #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaundon
force-pushed
the
BPK-2106-fix-text-input
branch
from
63a7b85 to
3411a10
Compare
shaundon
force-pushed
the
BPK-2106-fix-text-input
branch
from
3411a10 to
b3c99d8
Compare
matthewdavidson
approved these changes
Dec 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: facebook/react-native#22637
Line height is deprecated, so this was on our list of things to do anyway. It seems like this doesn't affect the visuals at all, but I'd appreciate a second pair of eyes.
Before:
After: