Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BpkCardList #3076

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

BpkCardList #3076

wants to merge 77 commits into from

Conversation

FireRedNinja
Copy link
Contributor

@FireRedNinja FireRedNinja commented Nov 8, 2023 •
edited
Loading

This PR add the new component BpkCardList.

Screenshots

Rail

image

Grid

image

Row

Stack

Remember to include the following changes:

  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2023

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@olliecurtis olliecurtis added the minor Non breaking change label Nov 10, 2023
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

FireRedNinja
FireRedNinja commented Jul 3, 2024
View reviewed changes
packages/bpk-component-carousel/src/BpkCarousel.tsx
@@ -18,7 +18,6 @@

import { useRef, useState } from 'react';

// @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript error was throwing on build

FireRedNinja
FireRedNinja commented Jul 3, 2024
View reviewed changes
packages/bpk-component-chip-group/src/BpkMultiSelectChipGroup.tsx
@@ -21,7 +21,6 @@ import { useRef } from 'react';
import BpkBreakpoint, { BREAKPOINTS } from '../../bpk-component-breakpoint';
import BpkSelectableChip, { BpkDismissibleChip, BpkIconChip, BpkDropdownChip, CHIP_TYPES } from '../../bpk-component-chip';
import FilterIconSm from '../../bpk-component-icon/sm/filter';
// @ts-expect-error Untyped import. See `decisions/imports-ts-suppressions.md`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typescript error was throwing on build

@Skyscanner Skyscanner deleted a comment from github-actions bot Jul 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024 •
edited
Loading

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 5006ce4

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

olliecurtis
olliecurtis requested changes Jul 24, 2024
View reviewed changes
examples/bpk-component-card-list/examples.module.css Outdated Show resolved Hide resolved
examples/bpk-component-card-list/examples.js Outdated Show resolved Hide resolved
examples/bpk-component-card-list/examples.js Outdated Show resolved Hide resolved
examples/bpk-component-card-list/examples.js Outdated Show resolved Hide resolved
examples/bpk-component-card-list/examples.module.scss Outdated Show resolved Hide resolved
packages/bpk-component-card-list/src/common-types.ts Outdated Show resolved Hide resolved
packages/bpk-component-card-list/src/common-types.ts Outdated Show resolved Hide resolved
packages/bpk-component-card-list/src/common-types.ts Outdated Show resolved Hide resolved
packages/bpk-component-mobile-scroll-container/index.d.ts Outdated Show resolved Hide resolved
packages/bpk-component-page-indicator/index.d.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Visit https://backpack.github.io/storybook-prs/3076 to see this build running in a browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@runmoore runmoore runmoore left review comments

@youngji0827 youngji0827 youngji0827 left review comments

@olliecurtis olliecurtis olliecurtis requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
minor Non breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@FireRedNinja @olliecurtis @mungodewar @runmoore @youngji0827