[LUNA-1331] [BpkCheckbox] Add ARIA label prop #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit https://backpack.github.io/storybook-prs/3544 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3544 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3544 to see this build running in a browser. |
|
Visit https://backpack.github.io/storybook-prs/3544 to see this build running in a browser. |
Comment on lines
+32
to
+43
|
|
||
| it('should render using label as aria-label if no ariaLabel prop provided', async () => { | ||
| render(<BpkCheckbox name="checkbox" label="Prefer directs" />); | ||
| const label = screen.getByLabelText('Prefer directs'); | ||
| expect(label).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| it('should render using ariaLabel prop as aria-label if prop provided', async () => { | ||
| render(<BpkCheckbox name="checkbox" label="Prefer directs" ariaLabel="aria label test string"/>); | ||
| const ariaLabel = screen.getByLabelText('aria label test string'); | ||
| expect(ariaLabel).toBeInTheDocument(); | ||
| }); |
There was a problem hiding this comment.
I'd maybe add another test that should render using ariaLabel when both aria-label and label are provided [completely optional to add]
|
Will come back round to this as we recently had a similar query from Luna and aria label wasn't necessarily the best way to do this. Will dig out the conversation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md