NO-JIRA: Added submit to loading button props

[amburrrshand]

Minor change to add the submit prop to the loading button props. Due to confusion in the past, it's probably best to make the submit prop type for the loading button explicit for consumers of Backpack as in the past, some users have set the type to be submit without knowing the submit prop exists and inherits the props from BpkButton via ...rest

Remember to include the following changes:

• Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
• README.md (If you have created a new component)
• Component README.md
• Tests
• Accessibility tests
  • The following checks were performed:
    • Ability to navigate using a keyboard only
    • Zoom functionality (Deque University explanation):
      • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
      • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
    • Ability to navigate using a screen reader only
• Storybook examples created/updated
• For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

[github-actions]

Visit https://backpack.github.io/storybook-prs/3574 to see this build running in a browser.

[github-actions]

Visit https://backpack.github.io/storybook-prs/3574 to see this build running in a browser.

[github-actions]

	Warnings
⚠️	Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?
⚠️	Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 902a6f9

[github-actions]

Visit https://backpack.github.io/storybook-prs/3574 to see this build running in a browser.

[anambl]

ohh this one should probably sit in the bpk-component-loading-button example file 😄

[github-actions]

Visit https://backpack.github.io/storybook-prs/3574 to see this build running in a browser.

[github-actions]

Visit https://backpack.github.io/storybook-prs/3574 to see this build running in a browser.

[anambl]

Awesome! I think it'd be a patch rather than minor though? Wdyt? 🤔

[amburrrshand]

Awesome! I think it'd be a patch rather than minor though? Wdyt? 🤔

Yeah I agree, thanks!