Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA]: Correct React semver range #3598

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

olliecurtis
Copy link
Member

This PR corrects the semver range for the react dependencies. As it turns out ^x.x.x - x.x.x is not correct syntax for the range and we need to drop the ^ when using a - range

More detail here: https://semver.npmjs.com/#syntax-examples

Without it it causes the following errors on install:

While resolving: <dependency-name-here>@0.0.0
   Found: react@18.3.1
   node_modules/react
     dev react@"18.3.1" from the root project
   Could not resolve dependency:
     peer react@"^17.0.2 - 18.3.1" from @skyscanner/backpack-web@35.0.0
     node_modules/@skyscanner/backpack-web
        dev @skyscanner/backpack-web@"^35.0.0" from the root project

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the patch Patch production bug label Aug 28, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3598 to see this build running in a browser.

@olliecurtis olliecurtis merged commit 4a9e3a3 into main Aug 28, 2024
10 checks passed
@olliecurtis olliecurtis deleted the no-jira-correcting-ranges branch August 28, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants