Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPY-889 Add xsmall to BpkPrice component #3643

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

toveadamsson
Copy link
Contributor

@toveadamsson toveadamsson commented Oct 16, 2024

Description
Currently, 16px is not available in Backpack Price. The minimun font-size available is 20px.
In this task, we should contribute to Backpack to include the 16px option, to be able to use it in our new Unified xSell components

  • Added xsmall type and include new size in BpkPrice
  • Updated unit test
  • Updated snapshots
  • Added stories
BpkPrice xsmall styles
Screenshot 2024-10-16 at 16 12 50 Screenshot 2024-10-16 at 16 12 59

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

Copy link

Visit https://backpack.github.io/storybook-prs/3643 to see this build running in a browser.

Copy link

github-actions bot commented Oct 16, 2024

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 98817c4

@toveadamsson toveadamsson added the minor Non breaking change label Oct 16, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3643 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3643 to see this build running in a browser.

@toveadamsson toveadamsson changed the title CAPY-889 Add 16 px size to BpkPrice component CAPY-889 Add xsmall to BpkPrice component Oct 17, 2024
@toveadamsson toveadamsson marked this pull request as ready for review October 17, 2024 07:55
Copy link

@lucascomp lucascomp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@toveadamsson toveadamsson self-assigned this Oct 17, 2024
@jronald01 jronald01 merged commit 6a54c82 into main Oct 17, 2024
9 checks passed
@jronald01 jronald01 deleted the CAPY-889_add_new_size_to_BpkPrice branch October 17, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants