Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WEAV-2560][BpkSegmentedControl] Focus Border fix #3652

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

metalix2
Copy link
Contributor

@metalix2 metalix2 commented Oct 24, 2024

Remember to include the following changes:

Screen.Recording.2024-10-24.at.12.32.12.mov

As part of the guidance around focus we should omit the focus indicator in this instance.

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@metalix2 metalix2 added javascript Pull requests that update Javascript code patch Patch production bug labels Oct 24, 2024
@metalix2 metalix2 changed the title [WEAV-2560][BpkSegmentedControl] Border fix [WEAV-2560][BpkSegmentedControl] Focus Border fix Oct 24, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3652 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3652 to see this build running in a browser.

Copy link
Contributor

@Parisistan Parisistan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing unnecessary border ⭐

@metalix2 metalix2 merged commit 4e34364 into main Oct 24, 2024
9 checks passed
@metalix2 metalix2 deleted the WEAV-2560_segmented_border_fi branch October 24, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants