Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO JIRA][BpkSpinner]: Fix Spinner removing aria-hidden from element #3672

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

olliecurtis
Copy link
Member

@olliecurtis olliecurtis commented Nov 20, 2024

This PR fixes an issue that at generation/transpilation stage of the spinner in Backpack the code to mark the Spinner icons as aria-hidden is removed.

To solve this we follow the same process as the bpk-icons where gulp brings them to the project for use rather than them being pulled and transpiled from bpk-svgs

Before After
Screenshot 2024-11-20 at 15 28 23 Screenshot 2024-11-20 at 15 28 45

Evidence of previously missing property

Screenshot 2024-11-20 at 15 44 09

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the patch Patch production bug label Nov 20, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3672 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3672 to see this build running in a browser.

Copy link

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against c2fe647

Copy link
Contributor

@Parisistan Parisistan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A11y improved -- ⭐
introducing spinner in gulpfile instead of pulling from bpk-svgs

@olliecurtis olliecurtis merged commit ff329a0 into main Nov 20, 2024
9 checks passed
@olliecurtis olliecurtis deleted the no-jira-fix-spinner-for-a11y branch November 20, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants