Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LOOM-1942][BpkPrice]: Fix right aligned price layout #3675

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

olliecurtis
Copy link
Member

@olliecurtis olliecurtis commented Nov 22, 2024

Fixes the layout of the leading text of the BpkPrice component. It was incorrectly laid out where when right aligned the previous price was swapped with the subtext, as if it was RTL instead of just right aligned.

Design

Screenshot 2024-11-22 at 16 31 40

Screenshots

Before After
Screenshot 2024-11-22 at 16 30 13 Screenshot 2024-11-22 at 16 30 52

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@olliecurtis olliecurtis added the patch Patch production bug label Nov 22, 2024
Copy link

Visit https://backpack.github.io/storybook-prs/3675 to see this build running in a browser.

@olliecurtis olliecurtis merged commit ba16506 into main Nov 22, 2024
10 checks passed
@olliecurtis olliecurtis deleted the loom-1942-fix-right-aligned-price-layout branch November 22, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Patch production bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants