[NO JIRA]: Update compliation of stylesheets #3707
Merged
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliecurtis
commented
Jan 10, 2025
| @@ -19,7 +19,7 @@ | |||
| "build": "run-s build:*", | |||
| "build:gulp": "gulp", | |||
| "build:unstable__bpk-mixins": "./scripts/scss/generate-unstable__bpk-mixins.sh", | |||
| "build:sass": "node scripts/scss/styles-prod.js && rm packages/bpk-stylesheets/index.css", | |||
There was a problem hiding this comment.
We shouldn't delete this file as we need it
olliecurtis
commented
Jan 10, 2025
| "transpile:copy-css": "node scripts/transpilation/copy-css.js", | ||
| "transpile:copy-utils": "node scripts/transpilation/copy-utils.js", | ||
| "transpile:imports": "node scripts/transpilation/transform-js-scss-css-imports.js", |
There was a problem hiding this comment.
Changing the order so that we will capture bpk-stylesheets otherwise the import change would happen before bpk-stylesheets was ready
olliecurtis
commented
Jan 10, 2025
Comment on lines
+126
to
+128
| new MiniCssExtractPlugin({ | ||
| filename: 'index.css', | ||
| }), |
There was a problem hiding this comment.
This complies the code to strip out non browser understandable sass such as global()
olliecurtis
commented
Jan 10, 2025
| @@ -46,7 +46,7 @@ console.log('Crunching import paths...'); | |||
| // eslint-disable-next-line no-console | |||
| console.log(''); | |||
|
|
|||
| const findReplaces = [{ find: '.module.scss', replace: '.module.css' }]; | |||
| const findReplaces = [{ find: '.scss', replace: '.css' }]; | |||
There was a problem hiding this comment.
Changing this here rather than renaming the files in bpk-stylesheets as that would have created a breaking change folks would need to do if they were using the sass stylesheets over the js
|
Visit https://backpack.github.io/storybook-prs/3707 to see this build running in a browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our transpilation process to fix an issue that when we are generating the
bpk-stylesheetsthe imports in the specific files for styles were not being updated to.cssand remained as.scsswhich meant that consumers would have to do further Backpack transpilation on their side when using this component through the js meansRemember to include the following changes:
[KOA-123][BpkButton] Updating the colourREADME.md(If you have created a new component)README.md