-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[QUAR-642] [BpkCardWrapper] Add more info button and body section to card wrapper #3730
base: main
Are you sure you want to change the base?
Conversation
Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser. |
Browser supportIf this is a visual change, make sure you've tested it in multiple browsers. |
Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser. |
Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser. |
https://skyscanner.atlassian.net/browse/QUAR-642
Figma designs: https://www.figma.com/design/22unPHkDCzqJkd9rKzTiGY/T%26Cs-Ads?node-id=79-11694&t=MTrz7gFIDvIgP4k2-4
For the inline ads, we need to have a dropdown box for T&C in the ad card wrapper. We're currently use a custom component to do this for desktop ads, but we need to add it to mobile ads as well. Instead of duplicating the custom wrapper into the mobile web ad components, we want to use the
BpkCardWrapper
component instead. To use it though we need to add themore info
button and dropdown body element.Remember to include the following changes:
[KOA-123][BpkButton] Updating the colour
README.md
(If you have created a new component)README.md