Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUAR-642] [BpkCardWrapper] Add more info button and body section to card wrapper #3730

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

kirstybryce
Copy link
Contributor

https://skyscanner.atlassian.net/browse/QUAR-642

Figma designs: https://www.figma.com/design/22unPHkDCzqJkd9rKzTiGY/T%26Cs-Ads?node-id=79-11694&t=MTrz7gFIDvIgP4k2-4

For the inline ads, we need to have a dropdown box for T&C in the ad card wrapper. We're currently use a custom component to do this for desktop ads, but we need to add it to mobile ads as well. Instead of duplicating the custom wrapper into the mobile web ad components, we want to use the BpkCardWrapper component instead. To use it though we need to add the more info button and dropdown body element.

Remember to include the following changes:

  • Ensure the PR title includes the name of the component you are changing so it's clear in the release notes for consumers of the changes in the version e.g [KOA-123][BpkButton] Updating the colour
  • README.md (If you have created a new component)
  • Component README.md
  • Tests
  • Accessibility tests
    • The following checks were performed:
      • Ability to navigate using a keyboard only
      • Zoom functionality (Deque University explanation):
        • The page SHOULD be functional AND readable when only the text is magnified to 200% of its initial size
        • Pages must reflow as zoom increases up to 400% so that content continues to be presented in only one column i.e. Content MUST NOT require scrolling in two directions (both vertically and horizontally)
      • Ability to navigate using a screen reader only
  • Storybook examples created/updated
  • For breaking changes or deprecating components/properties, migration guides added to the description of the PR. If the guide has large changes, consider creating a new Markdown page inside the component's docs folder and link it here

@kirstybryce kirstybryce changed the title [QUAR-642] Add more info button and body section to card wrapper [QUAR-642] [BpkCardWrapper] Add more info button and body section to card wrapper Jan 29, 2025
Copy link

Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser.

Copy link

github-actions bot commented Jan 29, 2025

Warnings
⚠️

Package source files (e.g. packages/package-name/src/Component.js) were updated, but snapshots weren't. Have you checked that the tests still pass?

⚠️

Package source files (e.g. packages/package-name/src/Component.tsx) were updated, but type files weren't. Have you checked that no types have changed?

Browser support

If this is a visual change, make sure you've tested it in multiple browsers.

Generated by 🚫 dangerJS against 7f3ca09

Copy link

Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser.

Copy link

Visit https://backpack.github.io/storybook-prs/3730 to see this build running in a browser.

@olliecurtis olliecurtis added the minor Non breaking change label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Non breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants