Skip to content

Commit

Permalink
record max_steps_per_run override in tasks table as well (#622)
Browse files Browse the repository at this point in the history
  • Loading branch information
wintonzheng authored Jul 19, 2024
1 parent 9c0c4cb commit 267335a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 0 deletions.
14 changes: 14 additions & 0 deletions skyvern/forge/agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,20 @@ async def execute_step(
# TODO: shall we send task response here?
return step, None, None

context = skyvern_context.current()
override_max_steps_per_run = context.max_steps_override if context else None
max_steps_per_run = (
override_max_steps_per_run
or task.max_steps_per_run
or organization.max_steps_per_run
or SettingsManager.get_settings().MAX_STEPS_PER_RUN
)
if max_steps_per_run and task.max_steps_per_run != max_steps_per_run:
await app.DATABASE.update_task(
task_id=task.task_id,
organization_id=organization.organization_id,
max_steps_per_run=max_steps_per_run,
)
next_step: Step | None = None
detailed_output: DetailedAgentStepOutput | None = None
num_files_before = 0
Expand Down
3 changes: 3 additions & 0 deletions skyvern/forge/sdk/db/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,7 @@ async def update_task(
extracted_information: dict[str, Any] | list | str | None = None,
failure_reason: str | None = None,
errors: list[dict[str, Any]] | None = None,
max_steps_per_run: int | None = None,
organization_id: str | None = None,
) -> Task:
if status is None and extracted_information is None and failure_reason is None and errors is None:
Expand All @@ -397,6 +398,8 @@ async def update_task(
task.failure_reason = failure_reason
if errors is not None:
task.errors = errors
if max_steps_per_run is not None:
task.max_steps_per_run = max_steps_per_run
await session.commit()
updated_task = await self.get_task(task_id, organization_id=organization_id)
if not updated_task:
Expand Down
2 changes: 2 additions & 0 deletions skyvern/forge/sdk/schemas/tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ def to_task_response(
screenshot_url=screenshot_url,
recording_url=recording_url,
errors=self.errors,
max_steps_per_run=self.max_steps_per_run,
)


Expand All @@ -236,6 +237,7 @@ class TaskResponse(BaseModel):
recording_url: str | None = None
failure_reason: str | None = None
errors: list[dict[str, Any]] = []
max_steps_per_run: int | None = None


class TaskOutput(BaseModel):
Expand Down

0 comments on commit 267335a

Please sign in to comment.