Skip to content

Commit

Permalink
Fix parameterized URL bug in task block (#815)
Browse files Browse the repository at this point in the history
  • Loading branch information
ykeremy authored Sep 12, 2024
1 parent 4a599bb commit 3e82a6a
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions skyvern/forge/sdk/workflow/models/block.py
Original file line number Diff line number Diff line change
Expand Up @@ -188,16 +188,7 @@ def get_all_parameters(
workflow_run_context = self.get_workflow_run_context(workflow_run_id)

if self.url and workflow_run_context.has_parameter(self.url):
if workflow_run_context.has_value(self.url):
LOG.info(
"Task URL is parameterized, using parameter value",
task_url_parameter_value=workflow_run_context.get_value(self.url),
task_url_parameter_key=self.url,
)
self.url = workflow_run_context.get_value(self.url)
else:
# if the parameter is not resolved yet, we'll add it to the list of parameters to resolve
# parameterization of the url would happen when the task is executed
if self.url not in [parameter.key for parameter in parameters]:
parameters.append(workflow_run_context.get_parameter(self.url))

return parameters
Expand Down

0 comments on commit 3e82a6a

Please sign in to comment.