mark workflow run failed if parameter creation failed (#1031)

Skyvern-AI · Oct 24, 2024 · 4d87b83 · 4d87b83
1 parent 1b635d6
commit 4d87b83
Showing 1 changed file with 28 additions and 24 deletions.
diff --git a/skyvern/forge/sdk/workflow/service.py b/skyvern/forge/sdk/workflow/service.py
@@ -121,30 +121,34 @@ async def setup_workflow_run(
 
         # Create all the workflow run parameters, AWSSecretParameter won't have workflow run parameters created.
         all_workflow_parameters = await self.get_workflow_parameters(workflow_id=workflow.workflow_id)
-        workflow_run_parameters = []
-        for workflow_parameter in all_workflow_parameters:
-            if workflow_request.data and workflow_parameter.key in workflow_request.data:
-                request_body_value = workflow_request.data[workflow_parameter.key]
-                workflow_run_parameter = await self.create_workflow_run_parameter(
-                    workflow_run_id=workflow_run.workflow_run_id,
-                    workflow_parameter=workflow_parameter,
-                    value=request_body_value,
-                )
-            elif workflow_parameter.default_value is not None:
-                workflow_run_parameter = await self.create_workflow_run_parameter(
-                    workflow_run_id=workflow_run.workflow_run_id,
-                    workflow_parameter=workflow_parameter,
-                    value=workflow_parameter.default_value,
-                )
-            else:
-                await self.mark_workflow_run_as_failed(workflow_run_id=workflow_run.workflow_run_id)
-                raise MissingValueForParameter(
-                    parameter_key=workflow_parameter.key,
-                    workflow_id=workflow.workflow_id,
-                    workflow_run_id=workflow_run.workflow_run_id,
-                )
-
-            workflow_run_parameters.append(workflow_run_parameter)
+        try:
+            for workflow_parameter in all_workflow_parameters:
+                if workflow_request.data and workflow_parameter.key in workflow_request.data:
+                    request_body_value = workflow_request.data[workflow_parameter.key]
+                    await self.create_workflow_run_parameter(
+                        workflow_run_id=workflow_run.workflow_run_id,
+                        workflow_parameter=workflow_parameter,
+                        value=request_body_value,
+                    )
+                elif workflow_parameter.default_value is not None:
+                    await self.create_workflow_run_parameter(
+                        workflow_run_id=workflow_run.workflow_run_id,
+                        workflow_parameter=workflow_parameter,
+                        value=workflow_parameter.default_value,
+                    )
+                else:
+                    raise MissingValueForParameter(
+                        parameter_key=workflow_parameter.key,
+                        workflow_id=workflow.workflow_id,
+                        workflow_run_id=workflow_run.workflow_run_id,
+                    )
+        except Exception as e:
+            LOG.exception(
+                f"Error while setting up workflow run {workflow_run.workflow_run_id}",
+                workflow_run_id=workflow_run.workflow_run_id,
+            )
+            await self.mark_workflow_run_as_failed(workflow_run_id=workflow_run.workflow_run_id)
+            raise e
 
         return workflow_run