Skip to content

Commit

Permalink
🔄 synced local 'skyvern-frontend/src/' with remote 'skyvern-frontend/…
Browse files Browse the repository at this point in the history
…src/'

<!-- ELLIPSIS_HIDDEN -->

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit d893ec0d6e77410d3255715d2dc1599c92c24b92  |
|--------|--------|

fix: auto-filter deleted parameters from `parameterKeys` in task nodes

### Summary:
Update `WorkflowParametersPanel` to auto-filter deleted parameters and add utility for `nodeAdder` identification.

**Key points**:
- **Behavior**: Deleting a parameter removes it from `parameterKeys` in `task` nodes; editing updates `parameterKeys` with the new key.
- **Utilities**: Add `isNodeAdderNode()` to identify `nodeAdder` nodes.
- **Types**: Change `NodeAdderNodeData` type to `Record<string, unknown>` to allow unknown properties.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
  • Loading branch information
ykeremy committed Sep 12, 2024
1 parent a6cc34e commit 87322d6
Show file tree
Hide file tree
Showing 2 changed files with 55 additions and 14 deletions.
28 changes: 14 additions & 14 deletions skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import { DeleteNodeCallbackContext } from "@/store/DeleteNodeCallbackContext";
import { useWorkflowPanelStore } from "@/store/WorkflowPanelStore";
import {
Background,
BackgroundVariant,
Expand All @@ -10,29 +12,27 @@ import {
useNodesState,
} from "@xyflow/react";
import "@xyflow/react/dist/style.css";
import { nanoid } from "nanoid";
import { useEffect, useState } from "react";
import { WorkflowParameterValueType } from "../types/workflowTypes";
import {
BitwardenLoginCredentialParameterYAML,
BlockYAML,
WorkflowParameterYAML,
} from "../types/workflowYamlTypes";
import { WorkflowHeader } from "./WorkflowHeader";
import { WorkflowParametersStateContext } from "./WorkflowParametersStateContext";
import { edgeTypes } from "./edges";
import { AppNode, nodeTypes } from "./nodes";
import { WorkflowNodeLibraryPanel } from "./panels/WorkflowNodeLibraryPanel";
import { WorkflowParametersPanel } from "./panels/WorkflowParametersPanel";
import "./reactFlowOverrideStyles.css";
import {
createNode,
generateNodeLabel,
getWorkflowBlocks,
layout,
} from "./workflowEditorUtils";
import { useEffect, useState } from "react";
import { WorkflowParametersPanel } from "./panels/WorkflowParametersPanel";
import { edgeTypes } from "./edges";
import { useWorkflowPanelStore } from "@/store/WorkflowPanelStore";
import { WorkflowNodeLibraryPanel } from "./panels/WorkflowNodeLibraryPanel";
import {
BitwardenLoginCredentialParameterYAML,
BlockYAML,
WorkflowParameterYAML,
} from "../types/workflowYamlTypes";
import { WorkflowParametersStateContext } from "./WorkflowParametersStateContext";
import { WorkflowParameterValueType } from "../types/workflowTypes";
import { DeleteNodeCallbackContext } from "@/store/DeleteNodeCallbackContext";
import { nanoid } from "nanoid";

function convertToParametersYAML(
parameters: ParametersState,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import {
DropdownMenuSeparator,
DropdownMenuTrigger,
} from "@/components/ui/dropdown-menu";
import { useReactFlow } from "@xyflow/react";

const WORKFLOW_EDIT_PANEL_WIDTH = 20 * 16;
const WORKFLOW_EDIT_PANEL_GAP = 1 * 16;
Expand All @@ -42,6 +43,7 @@ function WorkflowParametersPanel() {
parameter: null,
type: "workflow",
});
const { setNodes } = useReactFlow();

return (
<div className="relative w-[25rem] rounded-xl border border-slate-700 bg-slate-950 p-5 shadow-xl">
Expand Down Expand Up @@ -142,6 +144,22 @@ function WorkflowParametersPanel() {
(p) => p.key !== parameter.key,
),
);
setNodes((nodes) => {
return nodes.map((node) => {
if (node.type === "task") {
return {
...node,
data: {
...node.data,
parameterKeys: (
node.data.parameterKeys as Array<string>
).filter((key) => key !== parameter.key),
},
};
}
return node;
});
});
}}
>
Delete
Expand Down Expand Up @@ -202,6 +220,29 @@ function WorkflowParametersPanel() {
return parameter;
}),
);
setNodes((nodes) => {
return nodes.map((node) => {
if (node.type === "task") {
return {
...node,
data: {
...node.data,
parameterKeys: (
node.data.parameterKeys as Array<string>
).map((key) => {
if (
key === operationPanelState.parameter?.key
) {
return editedParameter.key;
}
return key;
}),
},
};
}
return node;
});
});
setOperationPanelState({
active: false,
operation: "edit",
Expand Down

0 comments on commit 87322d6

Please sign in to comment.