Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass organization id to launch browser #1000

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Oct 18, 2024

Important

Add organization_id parameter to browser state functions in browser_factory.py and browser_manager.py.

  • Behavior:
    • Add organization_id parameter to check_and_fix_state() and get_or_create_page() in browser_factory.py.
    • Add organization_id parameter to _create_browser_state() in browser_manager.py.
    • Pass organization_id in get_or_create_for_task() and get_or_create_for_workflow_run() in browser_manager.py.

This description was created by Ellipsis for 75060df. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 75060df in 14 seconds

More details
  • Looked at 130 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. skyvern/webeye/browser_factory.py:226
  • Draft comment:
    The organization_id parameter is added but not used in check_and_fix_state. Ensure it's necessary or implement its usage if needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds the organization_id parameter to several functions, but it doesn't seem to be used within those functions. This could be a missed implementation or an unnecessary addition.
2. skyvern/webeye/browser_factory.py:314
  • Draft comment:
    The organization_id parameter is added but not used in get_or_create_page. Ensure it's necessary or implement its usage if needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds the organization_id parameter to several functions, but it doesn't seem to be used within those functions. This could be a missed implementation or an unnecessary addition.
3. skyvern/webeye/browser_manager.py:43
  • Draft comment:
    The organization_id parameter is added but not used in _create_browser_state. Ensure it's necessary or implement its usage if needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds the organization_id parameter to several functions, but it doesn't seem to be used within those functions. This could be a missed implementation or an unnecessary addition.

Workflow ID: wflow_0u1Oz7DPmakIjfWl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@LawyZheng LawyZheng merged commit 533c814 into main Oct 18, 2024
2 checks passed
@LawyZheng LawyZheng deleted the lawy/pass-organization-id-to-launch-browser branch October 18, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant