Better represent available types for workflow parameters #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Add 'integer' type and rename 'number' to 'float' in workflow parameter options in `WorkflowParameterAddPanel.tsx` and `WorkflowParameterEditPanel.tsx`. > > - **Behavior**: > - Add 'integer' type to `workflowParameterTypeOptions` in `WorkflowParameterAddPanel.tsx` and `WorkflowParameterEditPanel.tsx`. > - Rename 'number' to 'float' in `workflowParameterTypeOptions` in both files. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for aa6b95180bc3ce6d85433504490d5a98c6043fe4. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 65465b3 in 11 seconds
More details
- Looked at
29lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:30
- Draft comment:
The change from 'number' to 'float' is correctly implemented here as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The PR description indicates that 'number' should be renamed to 'float'. The code correctly implements this change in both files.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:31
- Draft comment:
The change from 'number' to 'float' is correctly implemented here as per the PR description. - Reason this comment was not posted:
Confidence changes required:0%
The PR description indicates that 'number' should be renamed to 'float'. The code correctly implements this change in both files.
Workflow ID: wflow_yjgx6QfcXb4GWNbF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 65465b3 in 14 seconds
More details
- Looked at
29lines of code in2files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterAddPanel.tsx:30
- Draft comment:
Ensure that all references to 'number' in the codebase are updated to 'float' to maintain consistency. - Reason this comment was not posted:
Confidence changes required:50%
The PR description indicates that 'number' should be renamed to 'float'. The code changes reflect this correctly. However, I need to ensure that the rest of the codebase uses 'float' instead of 'number' to avoid inconsistencies.
2. skyvern-frontend/src/routes/workflows/editor/panels/WorkflowParameterEditPanel.tsx:31
- Draft comment:
Ensure that all references to 'number' in the codebase are updated to 'float' to maintain consistency. - Reason this comment was not posted:
Confidence changes required:50%
The PR description indicates that 'number' should be renamed to 'float'. The code changes reflect this correctly. However, I need to ensure that the rest of the codebase uses 'float' instead of 'number' to avoid inconsistencies.
Workflow ID: wflow_C4ygwZz5qJcp8LTX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add 'integer' type and rename 'number' to 'float' in workflow parameter options in
WorkflowParameterAddPanel.tsxandWorkflowParameterEditPanel.tsx.workflowParameterTypeOptionsinWorkflowParameterAddPanel.tsxandWorkflowParameterEditPanel.tsx.workflowParameterTypeOptionsin both files.This description was created by
for 65465b3. It will automatically update as commits are pushed.