Show error message correctly on workflow save #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> > [!IMPORTANT] > Improve error message display in `FlowRenderer.tsx` by using `detail` from error response if available. > > - **Behavior**: > - In `FlowRenderer.tsx`, update `onError` in `saveWorkflowMutation` to display `detail` from error response if available, otherwise use `error.message`. > - **Misc**: > - No other files or functions are affected. > > <sup>This description was created by </sup>[<img alt="Ellipsis" src="https://img.shields.io/badge/Ellipsis-blue?color=175173">](https://www.ellipsis.dev?ref=Skyvern-AI%2Fskyvern-cloud&utm_source=github&utm_medium=referral)<sup> for 89ad2066d47ab1255fbb073dae1871e9379a14a6. It will automatically update as commits are pushed.</sup> <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on cecb89a in 9 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:222
- Draft comment:
Ensure thaterror.response?.datais always an object before accessingdetailto avoid potential runtime errors. Consider using a type guard or defaulting to an empty object. - Reason this comment was not posted:
Confidence changes required:50%
The PR description indicates that the error message should usedetailif available, otherwiseerror.message. The implementation correctly checks fordetailand uses it if present.
Workflow ID: wflow_Oe1GPrhZndygH5LV
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to cecb89a in 9 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:222
- Draft comment:
Consider using a type guard or a more specific type assertion to ensure 'detail' is safely accessed. This can prevent runtime errors if the structure of 'error.response?.data' changes. - Reason this comment was not posted:
Confidence changes required:50%
The code correctly checks for the presence of 'detail' in the error response and uses it if available. However, the type assertion could be improved for better type safety.
Workflow ID: wflow_Bnxjt4hINo41qWnj
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Improve error message display in
FlowRenderer.tsxby usingdetailfrom error response if available.FlowRenderer.tsx, updateonErrorinsaveWorkflowMutationto displaydetailfrom error response if available, otherwise useerror.message.This description was created by
for cecb89a. It will automatically update as commits are pushed.