Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bitwarden collection id to workflow context #1053

Merged

Conversation

wintonzheng
Copy link
Contributor

@wintonzheng wintonzheng commented Oct 25, 2024

Important

Adds collection_id to get_secrets_from_password_manager() in context_manager.py for Bitwarden secret retrieval.

  • Behavior:
    • Adds collection_id to get_secrets_from_password_manager() in context_manager.py to retrieve secrets using this new identifier.
  • Misc:
    • No other changes or refactoring in the file.

This description was created by Ellipsis for de5ff50. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to de5ff50 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/context_manager.py:112
  • Draft comment:
    Ensure that collection_id is consistently set across the codebase to avoid potential inconsistencies. It is being set in both get_secrets_from_password_manager and register_parameter_value methods.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_Fl9M37vAcxZPKO1p


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wintonzheng wintonzheng merged commit c89be09 into main Oct 25, 2024
2 checks passed
@wintonzheng wintonzheng deleted the shu/add_bitwarden_collection_id_to_workflow_context branch October 25, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant