Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md to include Docker. #153

Merged
merged 9 commits into from
Apr 8, 2024

Conversation

martincarapia
Copy link
Contributor

@martincarapia martincarapia commented Apr 4, 2024

Just fill out the docker start description with the container_name/container_id, and then it should be ready for prod.
"
Run docker

docker start [options] [container_name/container_id]

"
Closes issue #147

Copy link
Contributor

@ykeremy ykeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋🏼 thank you so much for the PR

README.md Outdated
Comment on lines 95 to 98
1. Run docker
```bash
docker start [options] [container_name/container_id]
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the command to actually start running a docker container.

I thought the issue was the Docker Daemon / Docker Desktop not running.

We need an action item here that would prevent this check from failing:

skyvern/setup.sh

Lines 199 to 203 in 999eda9

# Check if Docker is installed and running
if ! command_exists docker || ! docker info > /dev/null 2>&1; then
echo "Docker is not running or not installed. Please install or start Docker and try again."
exit 1
fi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So would the solution be open Docker Daemon/Desktop?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly!

If you could tell how people can run it for each OS that would be perfect. I know it's not always easily possible from the CLI. So for windows you could just say run Docker Desktop, etc.

README.md Outdated Show resolved Hide resolved
@ykeremy
Copy link
Contributor

ykeremy commented Apr 8, 2024

Thanks for the PR @martincarapia, I'm gonna merge it.

@ykeremy ykeremy merged commit 9cf40d8 into Skyvern-AI:main Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants