Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary info in action result history #248

Merged
merged 1 commit into from
May 8, 2024

Commits on May 8, 2024

  1. 🔄 synced local 'skyvern/' with remote 'skyvern/'

    here's an example of a current action history:
    ```
    [
       {
          "action":{
             "action_type":"click",
             "description":null,
             "reasoning":"The user needs to submit a support request to resolve the issue with the job application submission flagged as bot traffic. The 'Submit a new support request' link with id 11 is the relevant element to click to access the support request form, as indicated by the previous successful action results and the current screenshot showing the Greenhouse support bot prompt.",
             "element_id":11,
             "file_url":null
          },
          "results":[
             {
                "success":false,
                "exception_type":"MissingElement",
                "exception_message":"Found no elements. Might be due to previous actions which removed this element. xpath=//*[@unique_id='11'] element_id=11",
                "data":null,
                "step_retry_number":0,
                "step_order":8,
                "javascript_triggered":false,
                "interacted_with_sibling":false,
                "interacted_with_parent":false
             }
          ]
       },
       {
          "action":{
             "action_type":"click",
             "description":null,
             "reasoning":"The user needs to submit a support request to resolve the issue with the job application submission flagged as bot traffic. The 'Get help' button with id 8 is the relevant element to click to access the support request form, as indicated by the current screenshot showing the Greenhouse support bot prompt.",
             "element_id":8,
             "file_url":null
          },
          "results":[
             {
                "success":true,
                "exception_type":null,
                "exception_message":null,
                "data":null,
                "step_retry_number":2,
                "step_order":8,
                "javascript_triggered":false,
                "interacted_with_sibling":false,
                "interacted_with_parent":false
             }
          ]
       },
       {
          "action":{
             "action_type":"input_text",
             "description":null,
             "reasoning":"The user needs to interact with the Greenhouse support bot to resolve the issue with the job application submission flagged as bot traffic. The 'Write a message' input field is the relevant element to input text into, as indicated by the current screenshot showing the Greenhouse support bot prompt. The user will explain the situation and request assistance.",
             "element_id":44,
             "file_url":null
          },
          "results":[
             {
                "success":false,
                "exception_type":"Error",
                "exception_message":"Error: Node is not an <input>, <textarea> or <select> element",
                "data":null,
                "step_retry_number":0,
                "step_order":9,
                "javascript_triggered":false,
                "interacted_with_sibling":false,
                "interacted_with_parent":false
             }
          ]
       }
    ]
    ```
    
    1. let's remove null
    2.             "javascript_triggered":false,
                "interacted_with_sibling":false,
                "interacted_with_parent":false
    these are definitely useless so let's remove them
    
    3. TBD: I'm not sure how important successful actions are - shall we remove?
    4.             "step_retry_number":0,
                "step_order":9,
    TBD: are these important at all?
    ykeremy authored and wintonzheng committed May 8, 2024
    Configuration menu
    Copy the full SHA
    35931f5 View commit details
    Browse the repository at this point in the history