New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use press_sequentially to replace fill #349

Merged

wintonzheng merged 1 commit into main from shu/use_press_sequentially_instead_of_fill

May 21, 2024

Contributor

ykeremy commented May 21, 2024 •

edited by wintonzheng

Loading

No description provided.


          🔄 synced local 'skyvern/' with remote 'skyvern/'

we fell back to locator.fill because the "clear + fill" was able to fix a bug we had.

now i ran into another bug on https://tickets.calacademy.org/account/create:

the "continue" button won't be enabled from the disabled status if we use fill (press_sequentially is more like what a human is doing)
<img width="638" alt="Screenshot 2024-05-17 at 9 19 52 PM" src="https://github.com/Skyvern-AI/skyvern-cloud/assets/5225702/2cdb7dba-6a8f-4695-b00e-066f23fe6ed5">

context: https://github.com/Skyvern-AI/skyvern-cloud/pull/401/files

ykeremy added the sync label

wintonzheng merged commit 0719396 into main

2 checks passed

wintonzheng deleted the shu/use_press_sequentially_instead_of_fill branch

May 21, 2024 02:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sync