Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomUtil optimize #350

Merged
merged 2 commits into from
May 21, 2024
Merged

DomUtil optimize #350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7bd2557
skip required check on <a>
LawyZheng May 21, 2024
b16c889
maxlength of non-interactable increase
LawyZheng May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions skyvern/webeye/scraper/domUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,8 +758,10 @@ function buildTreeFromBody() {
}
}

// character length limit for non-interactable elements should be 100
if (textContent && textContent.length <= 100) {
// character length limit for non-interactable elements should be 5000
// we don't use element context in HTML format,
// so we need to make sure we parse all text node to avoid missing text in HTML.
if (textContent && textContent.length <= 5000) {
var elementObj = buildElementObject(element, false);
elements.push(elementObj);
if (parentId === null) {
Expand Down Expand Up @@ -991,7 +993,8 @@ function buildTreeFromBody() {
element.context = context;
}

if (checkStringIncludeRequire(context)) {
// FIXME: skip <a> for now to prevent navigating to other page by mistake
if (element.tagName !== "a" && checkStringIncludeRequire(context)) {
if (
!element.attributes["required"] &&
!element.attributes["aria-required"]
Expand Down
Loading