Change shell scripts to run new UI #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 6dbf443 in 31 seconds
More details
- Looked at
70lines of code in3files - Skipped
1files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_6UKRswBas6hN7liB
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
ykeremy
reviewed
Jul 1, 2024
wintonzheng
reviewed
Jul 2, 2024
wintonzheng
reviewed
Jul 2, 2024
| @@ -127,7 +128,7 @@ Note: Our setup script does these two for you, but they are here for reference. | |||
| ```bash | |||
| ./run_ui.sh | |||
| ``` | |||
| 1. Navigate to `http://localhost:8501` in your browser to start using the UI | |||
| 1. Navigate to `http://localhost:8080` in your browser to start using the UI | |||
There was a problem hiding this comment.
is 8051 for streamlit and 8080 for our new UI?
wintonzheng
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updated shell scripts to support new UI setup and configure frontend environment.
Key points:
run_ui.shto navigate toskyvern-frontendand runnpm start.setup.shto ensurenpmis installed and to install frontend dependencies.setup.shto configureskyvern-frontend/.envwith the API token.skyvern-frontend/.env.exampleto includeVITE_SKYVERN_API_KEYplaceholder.Generated with ❤️ by ellipsis.dev