Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container util + ghost footer #539

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Jul 2, 2024

	- Use tailwind container util which sets max width based on screen size automatically
  • Add a footer without any content so that main content has some bottom padding and doesn't have to think about it itself

🚀 This description was created by Ellipsis for commit 503b654

Summary:

Replaced fixed max-width with Tailwind CSS container utility and added a footer for consistent bottom padding in layout components.

Key points:

  • Use Tailwind CSS container utility for responsive max-width in BillingPageLayout, SettingsPageLayout, TasksPageLayout, and CreateNewTaskLayout.
  • Add a footer with py-4 class to RootLayout components in skyvern-frontend/cloud/routes/root/RootLayout.tsx and skyvern-frontend/src/routes/root/RootLayout.tsx for consistent bottom padding.

Generated with ❤️ by ellipsis.dev

…src/'

- Use tailwind container util which sets max width based on screen size automatically
 - Add a footer without any content so that main content has some bottom padding and doesn't have to think about it itself
<!-- ELLIPSIS_HIDDEN -->

----

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit f53f1c7b207b81716814c9431d1616c1e5f09917  |
|--------|--------|

### Summary:
Replaced fixed max-width with Tailwind CSS `container` utility and added a footer for consistent bottom padding in layout components.

**Key points**:
- Use Tailwind CSS `container` utility for responsive max-width in `BillingPageLayout`, `SettingsPageLayout`, `TasksPageLayout`, and `CreateNewTaskLayout`.
- Add an empty footer with `py-4` class to `RootLayout` components in `skyvern-frontend/cloud/routes/root/RootLayout.tsx` and `skyvern-frontend/src/routes/root/RootLayout.tsx` for consistent bottom padding.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
@ykeremy ykeremy added the sync label Jul 2, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 503b654 in 44 seconds

More details
  • Looked at 56 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/root/RootLayout.tsx:45
  • Draft comment:
    The PR description mentions adding an empty footer with py-4 class for consistent bottom padding, but the change here only adds padding to the <main> element. If a footer is required as per the PR description, consider adding a footer element with the appropriate padding.
        <footer className="py-4"></footer>
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_f2NpvpKWuUdyXJmp


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 503b654 in 1 minute and 8 seconds

More details
  • Looked at 55 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skyvern-frontend/src/routes/root/RootLayout.tsx:45
  • Draft comment:
    The PR description mentions adding an empty footer with py-4 class for consistent bottom padding, but the changes here only add padding to the <main> element. Consider adding a separate footer element to match the PR's intent.
        <footer className="py-4"></footer>
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_NRq3l8DRj87RWIsU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 42e299a into main Jul 2, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/add-container-util branch July 2, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants