Mark options of disabled select non-interactable #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 6859f8db0e5577c96748b3158b84db57a8617935 | |--------|--------| ### Summary: Updated `isInteractable` function and added handling for invalid web actions, including updates to related classes and functions. **Key points**: - Updated `isInteractable` function in `skyvern/webeye/scraper/domUtils.js` to mark options of disabled or hidden select elements as non-interactable. - Added `check_for_invalid_web_action` function in `skyvern/webeye/actions/handler.py` to handle invalid web actions. - Modified `handle_action` function in `skyvern/webeye/actions/handler.py` to include the new invalid web action check. - Updated `ActionResult` class in `skyvern/webeye/actions/responses.py` to include `stop_execution_on_failure` attribute. - Adjusted `agent_step` function in `skyvern/forge/agent.py` to log warnings for failed actions that do not stop execution. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ad76ff0 in 1 minute and 7 seconds
More details
- Looked at
173lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:112
- Draft comment:
The implementation ofcheck_for_invalid_web_actionreturns anActionFailurewithstop_execution_on_failureset toFalsewhen an element ID is missing. This allows the execution to continue even if the action is invalid. Please confirm if this behavior is intended, as it might lead to further errors or unexpected behavior if the action sequence depends on the successful execution of previous actions. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_PcR76mBG9VcQrJbs
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on ad76ff0 in 1 minute and 16 seconds
More details
- Looked at
172lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/handler.py:171
- Draft comment:
Thecheck_for_invalid_web_actionfunction only checks for missing elements by ID but does not handle other types of invalid actions, such as interacting with disabled elements. Consider expanding this function to handle more cases where an action might be invalid. - Reason this comment was not posted:
Confidence of 40% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_tSb9H5zpZUiPuHEn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
LawyZheng
deleted the
suchintan.mark-options-of-disabled-select-non-interactable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Updated
isInteractablefunction and added handling for invalid web actions, including updates to related classes and functions.Key points:
isInteractablefunction inskyvern/webeye/scraper/domUtils.jsto mark options of disabled or hidden select elements as non-interactable.check_for_invalid_web_actionfunction inskyvern/webeye/actions/handler.pyto handle invalid web actions.handle_actionfunction inskyvern/webeye/actions/handler.pyto include the new invalid web action check.ActionResultclass inskyvern/webeye/actions/responses.pyto includestop_execution_on_failureattribute.agent_stepfunction inskyvern/forge/agent.pyto log warnings for failed actions that do not stop execution.Generated with ❤️ by ellipsis.dev