allow any origins to pass request to skyvern backend by default; make the ALLOWED_ORIGINS configurable through environment #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the ALLOWED_ORIGINS configurable through environment
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 4c1c302 in 32 seconds
More details
- Looked at
39lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_HvS3TM3vz7ntomuA
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -31,6 +31,7 @@ class Settings(BaseSettings): | |||
| JSON_LOGGING: bool = False | |||
| LOG_LEVEL: str = "INFO" | |||
| PORT: int = 8000 | |||
| ALLOWED_ORIGINS: list[str] = ["*"] | |||
There was a problem hiding this comment.
Setting ALLOWED_ORIGINS to ['*'] by default can lead to significant security vulnerabilities by allowing any website to interact with your API. Consider restricting this to a more conservative set of origins, or ensure that this setting is appropriately configured in production environments to avoid security risks.
msalihaltun
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Allow any origins by default and make allowed origins configurable via environment variables in
skyvern/config.pyandskyvern/forge/api_app.py.Key points:
skyvern/config.pyto addALLOWED_ORIGINSwith a default value of[*].skyvern/forge/api_app.pyto useSettingsManager.get_settings().ALLOWED_ORIGINSfor CORSallow_originsconfiguration.Generated with ❤️ by ellipsis.dev