Implement upload_file endpoint #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"\n<!-- ELLIPSIS_HIDDEN --> ---- | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 879e2ae0b4277fe6d57598a6242c1666e7779b6a | |--------|--------| ### Summary: Fixed typo in `validate_file_size` function and updated `detail` message to display file size in MB in `skyvern/forge/sdk/routes/agent_protocol.py`. **Key points**: - Fixed typo in `validate_file_size` function in `skyvern/forge/sdk/routes/agent_protocol.py`. - Changed `app.SETTINGS_MANAGER.MAX_FILE_SIZE` to `app.SETTINGS_MANAGER.MAX_UPLOAD_FILE_SIZE`. - Updated `detail` message to display file size in MB. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) ---- <!-- ELLIPSIS_HIDDEN -->\n"
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 501f35b in 33 seconds
More details
- Looked at
14lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:763
- Draft comment:
The PR description mentions fixing a typo, but the change from bytes to MB in the error message is a functional change, not a typo correction. Please update the PR description to accurately reflect this change. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_6L5f4WvjEkF5fHN5
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 501f35b in 36 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/routes/agent_protocol.py:763
- Draft comment:
The PR description mentions fixing a typo in thevalidate_file_sizefunction, but the diff does not reflect any typo corrections. Please ensure that all intended changes are included in the PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_d3OPogomudqhOrNz
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"\n
Summary:
Fixed typo in
validate_file_sizefunction and updateddetailmessage to display file size in MB inskyvern/forge/sdk/routes/agent_protocol.py.Key points:
validate_file_sizefunction inskyvern/forge/sdk/routes/agent_protocol.py.app.SETTINGS_MANAGER.MAX_FILE_SIZEtoapp.SETTINGS_MANAGER.MAX_UPLOAD_FILE_SIZE.detailmessage to display file size in MB.Generated with ❤️ by ellipsis.dev
\n"