Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add step prepare and browser clean up #554

Merged
merged 1 commit into from
Jul 4, 2024
Merged

add step prepare and browser clean up #554

merged 1 commit into from
Jul 4, 2024

Conversation

LawyZheng
Copy link
Collaborator

@LawyZheng LawyZheng commented Jul 4, 2024

🚀 This description was created by Ellipsis for commit ea97f7e

Summary:

Added step preparation and browser cleanup functionality across agent, agent_functions, browser_factory, and browser_manager modules.

Key points:

  • Added prepare_step_execution method in skyvern/forge/agent_functions.py to prepare for step execution.
  • Modified agent_step in skyvern/forge/agent.py to call prepare_step_execution before executing a step.
  • Updated BrowserContextFactory in skyvern/webeye/browser_factory.py to return a BrowserCleanupFunc.
  • Ensured BrowserCleanupFunc is called in BrowserState.close method in skyvern/webeye/browser_factory.py.
  • Updated BrowserManager in skyvern/webeye/browser_manager.py to handle the new BrowserCleanupFunc.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to ea97f7e in 42 seconds

More details
  • Looked at 178 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_X0BHlS97Ky2FavHk


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

skyvern/forge/agent_functions.py Show resolved Hide resolved
@LawyZheng LawyZheng merged commit be97d0b into main Jul 4, 2024
2 checks passed
@LawyZheng LawyZheng deleted the add-step-prepare branch July 4, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant