Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for handling Shadow DOM elements in the scraping process, including updates to select2 dropdown interactions.
Key points:
isInteractable
inskyvern/webeye/scraper/domUtils.js
to returnfalse
for elements withshadowRoot
.getSelect2OptionElements
andgetSelect2Options
inskyvern/webeye/scraper/domUtils.js
to accept anelement
parameter and use its root node.getDOMElementBySkyvenElement
inskyvern/webeye/scraper/domUtils.js
to locate elements within shadow roots.buildTreeFromBody
inskyvern/webeye/scraper/domUtils.js
to handle shadow DOM elements and their children.get_select2_options
inskyvern/webeye/scraper/scraper.py
to accept anelement
parameter.Select2Dropdown.get_options
inskyvern/webeye/utils/dom.py
to pass the element toget_select2_options
.Generated with ❤️ by ellipsis.dev