Implement get workflow runs endpoint #558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 97fb52dc2ee75066376dcde77fd269edce2921e6 | |--------|--------| ### Summary: Implemented endpoints to fetch workflow runs by `workflow_id`, `organization_id`, and `workflow_permanent_id` with pagination. **Key points**: - Added `get_workflow_runs_by_workflow_id` method in `skyvern/forge/sdk/db/client.py` to fetch workflow runs by `workflow_id` and `organization_id` with pagination. - Added `get_workflow_runs` method in `skyvern/forge/sdk/db/client.py` to fetch workflow runs by `organization_id` with pagination. - Added `get_workflow_runs_for_workflow_permanent_id` method in `skyvern/forge/sdk/db/client.py` to fetch workflow runs by `workflow_permanent_id` and `organization_id` with pagination. - Introduced `get_workflow_runs_by_workflow_id` method in `skyvern/forge/sdk/workflow/service.py` to call the database method for fetching workflow runs by `workflow_id` and `organization_id`. - Introduced `get_workflow_runs` method in `skyvern/forge/sdk/workflow/service.py` to call the database method for fetching workflow runs by `organization_id`. - Introduced `get_workflow_runs_for_workflow_permanent_id` method in `skyvern/forge/sdk/workflow/service.py` to call the database method for fetching workflow runs by `workflow_permanent_id` and `organization_id`. - Created `get_workflow_runs` endpoint in `skyvern/forge/sdk/routes/agent_protocol.py` to expose the functionality via API. - Created `get_workflow_runs_for_workflow_permanent_id` endpoint in `skyvern/forge/sdk/routes/agent_protocol.py` to expose the functionality via API. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 7d3dc50 in 44 seconds
More details
- Looked at
149lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:367
- Draft comment:
The method signature forget_workflow_runsincorrectly includes aworkflow_idparameter which is not used. This should be removed to match the actual usage and the corresponding database method signature.
async def get_workflow_runs(self, organization_id: str, page: int = 1, page_size: int = 10) -> list[WorkflowRun]:
- Reason this comment was not posted:
Based on historical feedback, this comment is too similar to comments previously marked by users as bad.
Workflow ID: wflow_g49fEUlKzysmkso1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7d3dc50 in 59 seconds
More details
- Looked at
150lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_5g9HaNVlJMDhMnWg
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -364,6 +364,19 @@ async def delete_workflow_by_permanent_id( | |||
| organization_id=organization_id, | |||
| ) | |||
|
|
|||
| async def get_workflow_runs(self, organization_id: str, page: int = 1, page_size: int = 10) -> list[WorkflowRun]: | |||
There was a problem hiding this comment.
The implementation of get_workflow_runs and get_workflow_runs_for_workflow_permanent_id methods incorrectly uses organization_id for filtering workflow runs. These methods should filter based on workflow_id and workflow_permanent_id respectively to correctly fetch the desired workflow runs. Please adjust the database queries accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented endpoints to fetch workflow runs by
workflow_id,organization_id, andworkflow_permanent_idwith pagination.Key points:
get_workflow_runs_by_workflow_idmethod inskyvern/forge/sdk/db/client.pyto fetch workflow runs byworkflow_idandorganization_idwith pagination.get_workflow_runsmethod inskyvern/forge/sdk/db/client.pyto fetch workflow runs byorganization_idwith pagination.get_workflow_runs_for_workflow_permanent_idmethod inskyvern/forge/sdk/db/client.pyto fetch workflow runs byworkflow_permanent_idandorganization_idwith pagination.get_workflow_runs_by_workflow_idmethod inskyvern/forge/sdk/workflow/service.pyto call the database method for fetching workflow runs byworkflow_idandorganization_id.get_workflow_runsmethod inskyvern/forge/sdk/workflow/service.pyto call the database method for fetching workflow runs byorganization_id.get_workflow_runs_for_workflow_permanent_idmethod inskyvern/forge/sdk/workflow/service.pyto call the database method for fetching workflow runs byworkflow_permanent_idandorganization_id.get_workflow_runsendpoint inskyvern/forge/sdk/routes/agent_protocol.pyto expose the functionality via API.get_workflow_runs_for_workflow_permanent_idendpoint inskyvern/forge/sdk/routes/agent_protocol.pyto expose the functionality via API.Generated with ❤️ by ellipsis.dev