Add null check for credentials without emails #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 7a27cdd2e6a3d9fa2949a81b130c8b07eed67276 | |--------|--------| ### Summary: Added null check for email credentials in `is_valid_email` and updated its usage in `get_secret_value_from_url` method of `BitwardenService`. **Key points**: - Updated `is_valid_email` function in `skyvern/forge/sdk/services/bitwarden.py` to handle `None` values. - Modified `get_secret_value_from_url` method in `BitwardenService` to use the updated `is_valid_email` function. - Added a null check for email credentials to prevent errors when email is missing. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 64eeaeb in 1 minute and 5 seconds
More details
- Looked at
28lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/services/bitwarden.py:145
- Draft comment:
Consider providing a default value when fetching the username to ensure clarity and prevent any potential issues withNonevalues being passed around.
if is_valid_email(cred.get(BitwardenConstants.USERNAME, "")):
- Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_FL8yxfpdzSS8Pp2F
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added null check for email credentials in
is_valid_emailand updated its usage inget_secret_value_from_urlmethod ofBitwardenService.Key points:
is_valid_emailfunction inskyvern/forge/sdk/services/bitwarden.pyto handleNonevalues.get_secret_value_from_urlmethod inBitwardenServiceto use the updatedis_valid_emailfunction.Generated with ❤️ by ellipsis.dev