Add null check for credentials without emails #616
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added null check for email credentials in
is_valid_email
and updated its usage inget_secret_value_from_url
method ofBitwardenService
.Key points:
is_valid_email
function inskyvern/forge/sdk/services/bitwarden.py
to handleNone
values.get_secret_value_from_url
method inBitwardenService
to use the updatedis_valid_email
function.Generated with ❤️ by ellipsis.dev