Ykeremy/add ie proxy #663
Merged
Ykeremy/add ie proxy #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 019e6fa96bac1f47da47e4172ae0748de3f5d076 | |--------|--------| ### Summary: Added support for Irish residential proxies by updating configuration files, schemas, and scripts. **Key points**: - Added `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_IE` to `.env.cloud.example` and `cloud/config.py`. - Created Alembic migration script `alembic/versions/2024_07_31_0918-3700f75db669_add_residential_ie_to_proxylocation_enum.py` to add `RESIDENTIAL_IE` to `ProxyLocation` enum. - Updated `cloud/webeye/proxy.py` to handle `RESIDENTIAL_IE` in `build_proxy_config_webshare_io` and `build_proxy_config` functions. - Updated multiple infrastructure JSON files (`infra/job-definition-production.json`, `infra/job-definition-staging.json`, `infra/scraping-definition-sandbox.json`, `infra/task-definition-production.json`, `infra/task-definition-staging.json`, `infra/workflow-job-definition-production.json`, `infra/workflow-job-definition-staging.json`) to include `WEBSHARE_IO_RESIDENTIAL_PROXY_USERNAME_IE`. - Updated `skyvern/forge/sdk/schemas/tasks.py` to include `RESIDENTIAL_IE` in `ProxyLocation` enum. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 22c516a in 26 seconds
More details
- Looked at
60lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:20
- Draft comment:
The addition ofRESIDENTIAL_IEto theProxyLocationenum is correctly implemented. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions that theRESIDENTIAL_IEenum value was added to theProxyLocationenum inskyvern/forge/sdk/schemas/tasks.py. The code change correctly reflects this addition. This is a straightforward addition and seems to be correctly implemented with no apparent issues or violations of best practices.
Workflow ID: wflow_PTqLYSfH75lt0y2m
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 22c516a in 34 seconds
More details
- Looked at
59lines of code in3files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/schemas/tasks.py:20
- Draft comment:
The addition ofRESIDENTIAL_IEto theProxyLocationenum is consistent with the PR's intent to support Irish residential proxies. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions adding support for Irish residential proxies by updating configuration files, schemas, and scripts. The addition ofRESIDENTIAL_IEto theProxyLocationenum inskyvern/forge/sdk/schemas/tasks.pyis consistent with this description. This change is necessary for the system to recognize and handle the new proxy type correctly.
Workflow ID: wflow_YJgozE7gsmQETCfp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on bdb5125 in 56 seconds
More details
- Looked at
46lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/__init__.py:1
- Draft comment:
The changes in this file seem unrelated to the PR's stated purpose of adding support for Irish residential proxies. Please confirm if these changes are intended to be part of this PR. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_XV9fjzSGYknXc0o7
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.