Detailed logs for webhook failures #691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit ddeae74ac4ac0364f2c99917a810ca8648fbd335 | |--------|--------| ### Summary: Removed JSON response logging in `send_workflow_response`, affecting webhook response logging behavior. **Key points**: - Removed JSON response logging in `send_workflow_response` function. - Affects `skyvern/forge/sdk/workflow/service.py`. - Removed `resp_json=resp.json()` from logging when webhook fails. - Changes logging behavior for webhook responses. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d5e9dd6 in 48 seconds
More details
- Looked at
17lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:729
- Draft comment:
Removingresp_json=resp.json()from the logging could potentially remove valuable debugging information, making it harder to diagnose issues with webhook failures. Consider keeping this or ensuring that the necessary information is logged in another way. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_U94raXvFKYUfrMb9
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on d5e9dd6 in 53 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/workflow/service.py:729
- Draft comment:
Removingresp.json()from the logs reduces the amount of detailed information available for debugging webhook failures. Ensure this change aligns with the intended logging and troubleshooting practices. - Reason this comment was not posted:
Confidence of 30% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_xvJJe2y9wqxxixIp
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Remove JSON response logging in
send_workflow_response, affecting webhook response logging behavior.Key points:
send_workflow_responsefunction.skyvern/forge/sdk/workflow/service.py.resp_json=resp.json()from logging on webhook failure.Generated with ❤️ by ellipsis.dev