add support for gpt-4o-2024-08-06 #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d62efad in 6 seconds
More details
- Looked at
16lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/forge/sdk/api/llm/config_registry.py:91
- Draft comment:
The new configuration for "OPENAI_GPT-4O-2024-08-06" is added correctly and follows the existing pattern for registering configurations. - Reason this comment was not posted:
Confidence changes required:0%
The new configuration for "OPENAI_GPT-4O-2024-08-06" is added without any issues. It follows the existing pattern for registering configurations.
Workflow ID: wflow_o3btHpRmCG0JGs3q
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
suchintan
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added support for
gpt-4o-2024-08-06inconfig_registry.pywith vision support and no assistant prefix.Key points:
gpt-4o-2024-08-06inskyvern/forge/sdk/api/llm/config_registry.py.LLMConfigwith keyOPENAI_GPT-4O-2024-08-06.supports_vision=Trueandadd_assistant_prefix=False.OPENAI_API_KEYenvironment variable.Generated with ❤️ by ellipsis.dev