Move navigation payload inside advanced accordion #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 0d750f1ceae4a8e7ede2a4bd6aed89fc7ca9e3c2 | |--------|--------| ### Summary: Moved `navigationPayload` form field into 'Advanced Settings' accordion in both `CreateNewTaskForm.tsx` and `SavedTaskForm.tsx`. **Key points**: - Moved `navigationPayload` form field into 'Advanced Settings' accordion in `skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx`. - Moved `navigationPayload` form field into 'Advanced Settings' accordion in `skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx`. - Ensures `navigationPayload` is treated as an advanced setting in both task creation forms. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
msalihaltun
changed the title
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2798365 in 13 seconds
More details
- Looked at
176lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:334
- Draft comment:
Consider aligning the schema validation with the transformation logic for 'navigationPayload' to ensure consistency. This applies to both CreateNewTaskForm.tsx and SavedTaskForm.tsx. - Reason this comment was not posted:
Confidence changes required:50%
The PR moves the 'navigationPayload' field into the 'Advanced Settings' accordion. This change is consistent across both files, and the implementation seems correct. However, I noticed that the 'navigationPayload' field is being transformed using a custom 'transform' function before being sent in the request. This transformation is not validated in the schema, which could lead to inconsistencies if the transformation logic changes. It would be better to ensure that the schema validation aligns with the transformation logic.
Workflow ID: wflow_TrSMHKBxx1d5rITL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 2798365 in 15 seconds
More details
- Looked at
175lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:334
- Draft comment:
Consider adding JSON validation fornavigationPayloadsimilar toextractedInformationSchemato ensure the payload is correctly formatted if JSON is expected. This applies to bothCreateNewTaskForm.tsxandSavedTaskForm.tsx. - Reason this comment was not posted:
Confidence changes required:50%
The PR moves thenavigationPayloadfield into the 'Advanced Settings' accordion. This change is consistent across bothCreateNewTaskForm.tsxandSavedTaskForm.tsx. However, thenavigationPayloadfield is not validated as JSON, which could lead to issues if the payload is expected to be JSON formatted. This is a potential oversight in both files.
Workflow ID: wflow_Q1MlbwVxmvPiZUm1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moved
navigationPayloadform field into 'Advanced Settings' accordion in task creation forms.Key points:
navigationPayloadform field into 'Advanced Settings' accordion inCreateNewTaskForm.tsx.navigationPayloadform field into 'Advanced Settings' accordion inSavedTaskForm.tsx.navigationPayloadis treated as an advanced setting in both task creation forms.Generated with ❤️ by ellipsis.dev