-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move navigation payload inside advanced accordion #718
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 0d750f1ceae4a8e7ede2a4bd6aed89fc7ca9e3c2 | |--------|--------| ### Summary: Moved `navigationPayload` form field into 'Advanced Settings' accordion in both `CreateNewTaskForm.tsx` and `SavedTaskForm.tsx`. **Key points**: - Moved `navigationPayload` form field into 'Advanced Settings' accordion in `skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx`. - Moved `navigationPayload` form field into 'Advanced Settings' accordion in `skyvern-frontend/src/routes/tasks/create/SavedTaskForm.tsx`. - Ensures `navigationPayload` is treated as an advanced setting in both task creation forms. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 2798365 in 13 seconds
More details
- Looked at
176
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:334
- Draft comment:
Consider aligning the schema validation with the transformation logic for 'navigationPayload' to ensure consistency. This applies to both CreateNewTaskForm.tsx and SavedTaskForm.tsx. - Reason this comment was not posted:
Confidence changes required:50%
The PR moves the 'navigationPayload' field into the 'Advanced Settings' accordion. This change is consistent across both files, and the implementation seems correct. However, I noticed that the 'navigationPayload' field is being transformed using a custom 'transform' function before being sent in the request. This transformation is not validated in the schema, which could lead to inconsistencies if the transformation logic changes. It would be better to ensure that the schema validation aligns with the transformation logic.
Workflow ID: wflow_TrSMHKBxx1d5rITL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 2798365 in 15 seconds
More details
- Looked at
175
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. skyvern-frontend/src/routes/tasks/create/CreateNewTaskForm.tsx:334
- Draft comment:
Consider adding JSON validation fornavigationPayload
similar toextractedInformationSchema
to ensure the payload is correctly formatted if JSON is expected. This applies to bothCreateNewTaskForm.tsx
andSavedTaskForm.tsx
. - Reason this comment was not posted:
Confidence changes required:50%
The PR moves thenavigationPayload
field into the 'Advanced Settings' accordion. This change is consistent across bothCreateNewTaskForm.tsx
andSavedTaskForm.tsx
. However, thenavigationPayload
field is not validated as JSON, which could lead to issues if the payload is expected to be JSON formatted. This is a potential oversight in both files.
Workflow ID: wflow_Q1MlbwVxmvPiZUm1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Summary:
Moved
navigationPayload
form field into 'Advanced Settings' accordion in task creation forms.Key points:
navigationPayload
form field into 'Advanced Settings' accordion inCreateNewTaskForm.tsx
.navigationPayload
form field into 'Advanced Settings' accordion inSavedTaskForm.tsx
.navigationPayload
is treated as an advanced setting in both task creation forms.Generated with ❤️ by ellipsis.dev