Fix bad error handling in task recording #737
Conversation
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 868509b6e6be2d47e58422f6bc214715b1a12c9f | |--------|--------| ### Summary: This PR improves error handling in `TaskRecording` by changing `useQuery` to return `string | null` and updating `getRecordingURL` to return `null` when no recording URL is available. **Key points**: - Update `useQuery` in `skyvern-frontend/src/routes/tasks/detail/TaskRecording.tsx` to return `string | null` instead of `string | undefined`. - Modify `getRecordingURL` in `skyvern-frontend/src/routes/tasks/detail/artifactUtils.ts` to return `null` when `task.recording_url` is absent. - Adjust error handling in `TaskRecording` to display "No recording available for this task" when `recordingURL` is `null`. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 04a1b19 in 10 seconds
More details
- Looked at
60lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_i2iVZw7z2LV5TWS3
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -22,7 +22,7 @@ export function getScreenshotURL(task: TaskApiResponse) { | |||
|
|
|||
| export function getRecordingURL(task: TaskApiResponse) { | |||
| if (!task.recording_url) { | |||
| return; | |||
| return null; | |||
There was a problem hiding this comment.
Consider returning null instead of undefined for consistency with getRecordingURL.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 04a1b19 in 17 seconds
More details
- Looked at
59lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_fuVRpTUQGeoledUX
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -13,11 +14,11 @@ function TaskRecording() { | |||
| data: recordingURL, | |||
| isLoading: taskIsLoading, | |||
| isError: taskIsError, | |||
| } = useQuery<string | undefined>({ | |||
| } = useQuery<string | null>({ | |||
There was a problem hiding this comment.
Consider adding retry: false to the useQuery options to prevent unnecessary retries when the recording URL is missing.
Summary:
This PR improves error handling in
TaskRecordingby updatinguseQueryandgetRecordingURLto handle missing recording URLs.Key points:
TaskRecording.useQueryinTaskRecording.tsxto returnstring | null.getRecordingURLinartifactUtils.tsto returnnulliftask.recording_urlis missing.recordingURLisnull.Generated with ❤️ by ellipsis.dev