update logging for task auto restart #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 46e054d10558e17d53814c48eaff0349c7f7294a | |--------|--------| ### Summary: This PR enhances logging and error handling in `scripts/run_task.py` and `skyvern/webeye/actions/models.py`, including a new log statement for task retryability. **Key points**: - Enhanced logging in `scripts/run_task.py` for detailed output after task execution. - Added log statement to check if a task is retryable in `scripts/run_task.py`. - Updated `skyvern/webeye/actions/models.py` to include `step_exception` in `get_clean_detailed_output` method. - Improved error handling and logging for task auto-restart scenarios. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to ae37a58 in 6 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern/webeye/actions/models.py:74
- Draft comment:
Thestep_exceptionfield is added toDetailedAgentStepOutputbut not used into_agent_step_output. Ensure this is intentional and not an oversight. - Reason this comment was not posted:
Confidence changes required:50%
The code inget_clean_detailed_outputmethod is clear and follows best practices. However, thestep_exceptionfield is added toDetailedAgentStepOutputbut not used into_agent_step_output. This might be intentional, but it's worth noting in case it was an oversight.
Workflow ID: wflow_vgHtQFmCUtLBOcmq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR enhances logging and error handling for task auto-restart in
scripts/run_task.pyandskyvern/webeye/actions/models.py, including a new log statement for task retryability andstep_exceptioninclusion inget_clean_detailed_output.Key points:
scripts/run_task.pyfor detailed output after task execution.scripts/run_task.py.get_clean_detailed_outputinskyvern/webeye/actions/models.pyto includestep_exception.Generated with ❤️ by ellipsis.dev