Add adder node after the first node is added #796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…src/' <!-- ELLIPSIS_HIDDEN --> | 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 0a993fa8ef99f15c6aa4bf39d7cd475539528163 | |--------|--------| ### Summary: Add `nodeAdder` node and edge in `FlowRenderer.tsx` when the first node is added to an empty workflow. **Key points**: - Modify `addNode` function in `skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx`. - Add `nodeAdder` node and edge when the first node is added to an empty workflow. - Ensure `nodeAdder` is present for further node additions. ---- Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev) <!-- ELLIPSIS_HIDDEN -->
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a9cfa49 in 20 seconds
More details
- Looked at
32lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx:192
- Draft comment:
Consider moving theif (nodes.length === 0)block before modifyingnewNodesAfterto ensure thenodeAdderis added only when the workflow is initially empty. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is suggesting a potential improvement in the logic flow. It is related to the new code added in the diff, and it is not asking for confirmation or speculative. It seems to be a valid suggestion for a code quality refactor.
The comment might be unnecessary if the current logic already handles the intended behavior correctly. It assumes that moving the block will improve the logic without concrete evidence.
The suggestion seems to be about improving code clarity and ensuring the logic is straightforward, which is generally beneficial.
The comment is about a change made in the diff and suggests a potential improvement in the logic. It should be kept as it is actionable and clear.
Workflow ID: wflow_ENk1G7AYMMpfo45f
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to a9cfa49 in 21 seconds
More details
- Looked at
33lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_xbCSMLAdi2EBjY0C
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -188,6 +188,27 @@ function FlowRenderer({ | |||
| ...newNodes, | |||
| ...nodes.slice(previousNodeIndex + 1), | |||
| ]; | |||
|
|
|||
| if (nodes.length === 0) { | |||
There was a problem hiding this comment.
The logic for adding a nodeAdder node and edge when the first node is added is duplicated. Consider refactoring to avoid redundancy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add
nodeAddernode and edge inFlowRenderer.tsxfor the first node in an empty workflow.Key points:
nodeAddernode and edge inFlowRenderer.tsxwhen the first node is added to an empty workflow.addNodefunction inskyvern-frontend/src/routes/workflows/editor/FlowRenderer.tsx.nodeAdderis present for further node additions.Generated with ❤️ by ellipsis.dev