Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add delete action in workflows table #802

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Conversation

ykeremy
Copy link
Contributor

@ykeremy ykeremy commented Sep 10, 2024

🚀 This description was created by Ellipsis for commit c403384

Summary:

Added delete functionality to workflows with DeleteWorkflowButton, updated GarbageIcon, and removed WorkflowsBetaAlertCard.

Key points:

  • Added DeleteWorkflowButton for workflow deletion.
  • Updated GarbageIcon to make className prop optional.
  • Removed WorkflowsBetaAlertCard from workflows.
  • Integrated DeleteWorkflowButton into workflows table.
  • Utilized react-query for mutation and axios for API calls.

Generated with ❤️ by ellipsis.dev

<!-- ELLIPSIS_HIDDEN -->

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 6ea20bb37cf65de9d6ad048ffdc697c0dd22264f  |
|--------|--------|

### Summary:
Added delete functionality to workflows table with `DeleteWorkflowButton`, updated `GarbageIcon`, and removed `WorkflowsBetaAlertCard`.

**Key points**:
- Added `DeleteWorkflowButton` component in `skyvern-frontend/src/routes/workflows/editor/DeleteWorkflowButton.tsx` to handle workflow deletion.
- Updated `GarbageIcon` in `skyvern-frontend/src/components/icons/GarbageIcon.tsx` to make `className` prop optional.
- Removed `WorkflowsBetaAlertCard` from `skyvern-frontend/src/routes/workflows/Workflows.tsx`.
- Integrated `DeleteWorkflowButton` into workflows table in `skyvern-frontend/src/routes/workflows/Workflows.tsx`.
- `DeleteWorkflowButton` uses `react-query` for mutation and `axios` for API calls.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
…src/'

<!-- ELLIPSIS_HIDDEN -->

| 🚀 | This description was created by [Ellipsis](https://www.ellipsis.dev) for commit 6ea20bb37cf65de9d6ad048ffdc697c0dd22264f  |
|--------|--------|

### Summary:
Added delete functionality to workflows table with `DeleteWorkflowButton`, updated `GarbageIcon`, and removed `WorkflowsBetaAlertCard`.

**Key points**:
- Added `DeleteWorkflowButton` component in `skyvern-frontend/src/routes/workflows/editor/DeleteWorkflowButton.tsx` to handle workflow deletion.
- Updated `GarbageIcon` in `skyvern-frontend/src/components/icons/GarbageIcon.tsx` to make `className` prop optional.
- Removed `WorkflowsBetaAlertCard` from `skyvern-frontend/src/routes/workflows/Workflows.tsx`.
- Integrated `DeleteWorkflowButton` into workflows table in `skyvern-frontend/src/routes/workflows/Workflows.tsx`.
- `DeleteWorkflowButton` uses `react-query` for mutation and `axios` for API calls.

----
Generated with ❤️ by [ellipsis.dev](https://www.ellipsis.dev)

<!-- ELLIPSIS_HIDDEN -->
@ykeremy ykeremy added the sync label Sep 10, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to d42a30a in 13 seconds

More details
  • Looked at 244 lines of code in 5 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_RDe1Ep5ohL1bVYbH


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

onClick={() => {
deleteWorkflowMutation.mutate(id);
}}
disabled={deleteWorkflowMutation.isPending}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleteWorkflowMutation.isPending should be deleteWorkflowMutation.isLoading to correctly disable the button during the mutation process.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on d42a30a in 20 seconds

More details
  • Looked at 228 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. skyvern-frontend/src/routes/workflows/editor/DeleteWorkflowButton.tsx:35
  • Draft comment:
    Consider adding validation to ensure id is provided and valid before attempting to delete the workflow. This can prevent potential runtime errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The deleteWorkflowMutation should handle the case where the id is not provided or is invalid. This can prevent potential runtime errors.
2. skyvern-frontend/src/routes/workflows/editor/DeleteWorkflowButton.tsx:67
  • Draft comment:
    Review the necessity of onCloseAutoFocus={(e) => e.preventDefault()}. Preventing default behavior might not be needed here.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The onCloseAutoFocus event handler is preventing the default behavior, which might not be necessary. It should be reviewed to ensure it's needed.
3. skyvern-frontend/src/components/icons/GarbageIcon.tsx:2
  • Draft comment:
    Consider providing a default value for className to avoid potential issues when it's undefined.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The className prop in GarbageIcon is optional, but it's being used directly without a default value. This might lead to issues if className is undefined.

Workflow ID: wflow_Wqj9abbc9s4esjdh


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on c403384 in 9 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_NvEWjbFKzInuOPBB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@msalihaltun msalihaltun merged commit 4800fe4 into main Sep 10, 2024
2 checks passed
@msalihaltun msalihaltun deleted the salih/workflow-delete-action branch September 10, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants